[Docs] Add module config reload docs #4930
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dedemorton
commented
Aug 17, 2017
| reload.period: 10s | ||
| ------------------------------------------------------------------------------ | ||
|
|
||
| TIP: If you are using the <<modules-command,`modules`>> command to enable and |
There was a problem hiding this comment.
@exekias I'm not sure if I'm going far enough here. I think it might be better to show the modules.d path in the config example here rather than just mentioning it as an aside. WDYT? (still need to write those docs...tomorrow)
There was a problem hiding this comment.
Yeah I think so, we show a common path from doc, while it's clear you can change it if you want
dedemorton
added
the
needs_backport
exekias
reviewed
Aug 17, 2017
| Each file found by the Glob must contain a list of one or more module | ||
| definitions. For example: | ||
|
|
||
| //REVIEWERS: I got an error when I tried to have an empty line before the -module: mysql entry below. Shouldn't whitespace be allowed there? |
There was a problem hiding this comment.
Uhm I think it should be allowed so we may file a bug for this?
There was a problem hiding this comment.
Weird. I was not able to reproduce this issue. Maybe I had a tab or something on that line? Anyhow...if I can't reproduce the problem, it doesn't exist, right? :-)
exekias
suggested changes
Aug 17, 2017
exekias
approved these changes
Aug 17, 2017
This was referenced Aug 18, 2017
dedemorton
removed
the
needs_backport
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.